This exercise is good for rotator cup, it could help increase shoulder strength as well as mobility, and it's a good warm-up workout, too. I think it could be a workout of rehab helping address rotator cup injuries. Doing the move with your back of the hand would be more beneficial because we seldom move our hand/arm that way, I think that could exercise the antagonists to the muscles we employ during swimming. The weak antagonist is often the reason that caused sports injuries.